Skip to content

Commit

Permalink
Merge branch 'release' into gh-pages
Browse files Browse the repository at this point in the history
* release: (303 commits)
  Updated script name for deploying
  we're not in 2014
  Updating release date and test files
  prep for release
  3.0.0 package.json update
  cleaning up Reservoir Versioning table
  v3 logo and homepage updates
  Update based on feedback
  Mixed up onClear and onClearAll functions for MultiSelect but this should fix it.
  General repo updates in preparation for v3
  Updating based on feedback
  updates based on feedback
  v3 migration guide
  Fixed code review comments
  Added focus on view all button after onclick on button
  Added focus on view all button after onclick on button
  Accordian panel is disappers when isblockElement is false
  DSD-1710: use onClearAll for clear the multi-select count
  First update
  rc3
  ...
  • Loading branch information
EdwinGuzman committed Mar 14, 2024
2 parents 5fc7cb4 + 3a92fad commit 5da8f79
Show file tree
Hide file tree
Showing 330 changed files with 16,890 additions and 40,236 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
CI: true
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- name: Cache and install node modules
uses: bahmutov/npm-install@v1
with:
Expand All @@ -32,10 +32,10 @@ jobs:
CI: true
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- name: Cache and install node modules
uses: bahmutov/npm-install@v1
- name: Test
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ jobs:
with:
persist-credentials: false

- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x

- name: Cache and install node modules
uses: bahmutov/npm-install@v1

- name: Build Storybook
env:
NODE_OPTIONS: "--max_old_space_size=4096"
run: npm run prebuild:storybook && npm run build-storybook:v2
run: npm run prebuild:storybook && npm run build-storybook:v3

- name: Deploy
uses: JamesIves/github-pages-deploy-action@releases/v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ jobs:
CI: true
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
registry-url: "https://registry.npmjs.org"
- name: Cache and install node modules
uses: bahmutov/npm-install@v1
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- name: Cache and install node modules
uses: bahmutov/npm-install@v1
- name: Build Storybook
env:
NODE_OPTIONS: "--max_old_space_size=4096"
run: npm run prebuild:storybook && npm run build-storybook:v2
run: npm run prebuild:storybook && npm run build-storybook:v3
- name: Setup Pages
uses: actions/configure-pages@v3
- name: Upload artifact
Expand Down
2 changes: 1 addition & 1 deletion .jest-test-results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18
6 changes: 3 additions & 3 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ const config: StorybookConfig = {
});
},

docs: {
autodocs: true,
},
// docs: {
// autodocs: true,
// },
};

export default config;
4 changes: 2 additions & 2 deletions .storybook/public/nypl-reservoir-design-system-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions CHAKRA_MIGRATION_GUIDE.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Chakra Migration Guide
# Legacy Chakra Migration Guide

The first Reservoir Design System (DS) version that includes the Chakra UI library is version `0.25.0`. This guide is meant for those who are using a version less than `0.25.0` and want to migrate to a version greater than or equal to `0.25.0`.
**IMPORTANT**: If you are using a DS version greater than 1.0, this guide does not apply.

If you are using a DS version greater than 1.0, this guide does not apply.
The first Reservoir Design System (DS) version that includes the Chakra UI library is version `0.25.0`. This guide is meant for those who are using a version less than `0.25.0` and want to migrate to a version greater than or equal to `0.25.0`.

If you would rather read documentation on the Design System's internal use of Chakra, check the Storybook documentation page. The following two links have the same information but in different formats for your reading preference:

- [MDX format](/src/docs/Chakra.stories.mdx)
- [Storybook page](https://nypl.github.io/nypl-design-system/reservoir/v2/?path=/docs/chakra-ui--docs)
- [Storybook page](https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/chakra-ui--docs)

| Table of Contents | |
| ----------------- | ----------------------------------------------------- |
Expand Down
47 changes: 38 additions & 9 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,40 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
Currently, this repo is in Prerelease. When it is released, this project will adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
========

## Prerelease
## 3.0.0 (March 14, 2024) React 18 / Chakra 2.8

### Adds

- Adds `5%` and `10%` opacities for the semantic colors in the color pallette.
- Adds the `Menu` component.
- Adds the `MultiSelect` v2 component.
- Adds the `useMultiSelect` hook.

### Updates

- Updates the repo to use Node 18.
- Updates to React 18 and Chakra 2.8.
- Updates the `StatusBadge` component to add the `type` prop.
- Updates the `StatusBadge` component to change the UI styles.
- Updates the base `Modal` component to use the `useDSHeading` hook internally to render a DS Heading for the `headingText` prop.
- Updates the `Heading` component to use native Chakra responsive styles to handle the font sizes of the component's internal `heading`, `overline` and `subtitle` elements. This also resolves the flashing font size bug that is most noticeable on slower internet connections.
- Updates the `Text` component to use native Chakra responsive styles for the font sizes of the `subtitle1` and `subtitle2` variants.
- Updates the `NewsletterSignup` component to follow NYPL recommendations and use more direct language for the email field error message.
- Updates the default export to include `FocusLock`, `useStyleConfig`, and `useMultiStyleConfig` from Chakra UI.
- Updates the default export to include the test helper "MatchMedia".
- Updates the `Accordion` component to include the `ariaLabel` and `buttonInteractionRef` props.
- Updates the `Tabs` component to use horizontal scrolling and arrow buttons step through tabs in mobile view.

### Fixes

- Removes console warnings from the `CheckboxGroup` component when a non-`Checkbox` component is passed as a child.
- Fixes the responsive styles related to the image in the `FeaturedContent` component.

### Breaking Changes

- Removes the `NewsletterSignup` and `SocialMediaLinks` components.
- Updates the `TagSet` component to allow for more properties in the tag data object. The `onClick` function now returns the entire data object in the callback argument instead of just the tag label.
- Updates the `Link` component to follow Chakra's patterns for usage with application framework routing systems, as well as a general refactor. Usage with Next.js has been updated.

## 2.1.6 (February 22, 2024)

Expand Down Expand Up @@ -43,21 +76,17 @@ Currently, this repo is in Prerelease. When it is released, this project will ad

### Adds

- Adds optional `placeholder` and `placeholderTo` props to the `DatePicker`
component.
- Adds optional `placeholder` and `placeholderTo` props to the `DatePicker` component.
- Adds the `"actionDelete"`, `"actionHome"`, `"actionLockClosed"`,
`"actionPayment"`, `"communicationCall"`, `"communicationChatBubble"`, and
`"communicationEmail"` options to the `Icon` component.
`"actionPayment"`, `"communicationCall"`, `"communicationChatBubble"`, and `"communicationEmail"` options to the `Icon` component.

### Updates

- Updates the `DatePicker`'s `initialDate` and `initialDateTo` props to accept
an empty string.
- Updates the `DatePicker`'s `initialDate` and `initialDateTo` props to accept an empty string.

### Fixes

- Fixes bug where month and year `Datepicker` calendars were rendering
vertically rather than horizontally.
- Fixes bug where month and year `Datepicker` calendars were rendering vertically rather than horizontally.

## 2.1.3 (December 7, 2023)

Expand Down
Loading

0 comments on commit 5da8f79

Please sign in to comment.