fix test failures

NYPL · Oct 2, 2023 · 29c44bb · 29c44bb
1 parent 5cebc38
commit 29c44bb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 37 deletions.
diff --git a/src/components/Hero/Hero.tsx b/src/components/Hero/Hero.tsx
@@ -165,8 +165,8 @@ export const Hero = chakra(
 
       if (!heroSecondaryTypes.includes(heroType)) {
         contentBoxStyling = {
-          ...(backgroundColor && { backgroundColor }),
           ...(foregroundColor && { color: foregroundColor }),
+          ...(backgroundColor && { backgroundColor }),
         };
       } else if (
         foregroundColor ||
@@ -230,6 +230,7 @@ export const Hero = chakra(
         >
           <Box
             data-testid="hero-content"
+            style={contentBoxStyling}
             __css={{ ...styles.content, ...contentBoxStyling }}
           >
             {childrenToRender}

diff --git a/src/components/Hero/__snapshots__/Hero.test.tsx.snap b/src/components/Hero/__snapshots__/Hero.test.tsx.snap
@@ -14,12 +14,7 @@ exports[`Hero Renders the UI snapshot correctly 1`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <h1
       className="chakra-heading css-eyyo6e"
@@ -240,12 +235,7 @@ exports[`Hero Renders the UI snapshot correctly 7`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <h1
       className="chakra-heading css-eyyo6e"
@@ -274,12 +264,7 @@ exports[`Hero Renders the UI snapshot correctly 8`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <div
       className="css-1gt4hjv"
@@ -318,12 +303,7 @@ exports[`Hero Renders the UI snapshot correctly 9`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <div
       className="css-1gt4hjv"
@@ -361,12 +341,7 @@ exports[`Hero Renders the UI snapshot correctly 10`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <h1
       className="chakra-heading css-eyyo6e"
@@ -397,12 +372,7 @@ exports[`Hero Renders the UI snapshot correctly 11`] = `
   <div
     className="css-0"
     data-testid="hero-content"
-    style={
-      {
-        "backgroundColor": undefined,
-        "color": undefined,
-      }
-    }
+    style={{}}
   >
     <h1
       className="chakra-heading css-eyyo6e"