Re-query ShopperTrak for missing sites #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| create_table_query = build_redshift_create_table_query( | ||
| self.redshift_visits_table, start_date, end_date | ||
| ) | ||
| self.redshift_client.connect() | ||
| found_site_dates = self.redshift_client.execute_query(found_sites_query) | ||
| self.redshift_client.execute_transaction([(create_table_query, None)]) |
There was a problem hiding this comment.
Why is execute_transaction used vs execute_query?
There was a problem hiding this comment.
Originally it was for executing a bunch of queries that depend on each other as part of the same transaction (e.g. don't delete rows in a table if the update to a different table fails). The naming is a bit of a relic though because now I mostly use it to do write queries (even outside of a transaction) whereas execute_query can only run read queries.
fatimarahman
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code checks for sites that did not appear in the ShopperTrak response for a given day, which is distinct from what we currently do (check for sites that appeared in the API response but had unhealthy data)