Gracefully exit when API rate limit is exceeded #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwbenowitz
approved these changes
May 16, 2024
Comment on lines
+186
to
+189
| if site_xml_root == "E104": | ||
| continue | ||
| elif site_xml_root == "E107": | ||
| break |
There was a problem hiding this comment.
Should probably log these out to help future you/us debug things when we're missing data.
There was a problem hiding this comment.
They get logged in the shoppertrak_api_client (lines 206-223) so I think we're good
| if response_root == "E104": | ||
| return None | ||
| elif response_root == "E108": | ||
| if response_root == "E108": |
There was a problem hiding this comment.
General question: do we have any documentation on all of the error states that ShopperTrak can return?
There was a problem hiding this comment.
ShopperTrak sent us some documentation with the following error codes, which notably does not include E104, making me wonder whether there are other possible error codes not included in this list:
- E101: The Site ID supplied is not recognized by the system.
- E102: The format of the “date” value is not valid. The format must be YYYYMMDD.
- E103: The requested date value is older than 30 days.
- E105: The total property value is not valid. This value must either be “Y” or “N”.
- E106: The increment value is not valid. This value must either be “15” or “60”.
- E107: Customer has exceeded the maximum number of requests allowed in a 24 hour period.
- E108: The web service is busy, please try again later. It is recommended to wait at least 30 seconds before making another request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected that we exceed the API limit (100 daily requests) when checking for recovery data and therefore we should not throw an error when this happens.