Skip to content

Commit

Permalink
Merge pull request #2163 from NYPL/SCC-4324/make-bib-link-on-hold-pag…
Browse files Browse the repository at this point in the history
…es-hit-reverse-proxy

SCC-4324 - Make bib link on hold pages hit reverse proxy
  • Loading branch information
dgcohen authored Oct 29, 2024
2 parents 3e1d27c + a0c4bc5 commit 88eb06c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/app/pages/HoldRequest.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import axios from 'axios';
import PropTypes from 'prop-types';
import React from 'react';
import { connect } from 'react-redux';
import { Link, withRouter } from 'react-router';
import { withRouter } from 'react-router';
import {
isArray as _isArray,
isEmpty as _isEmpty,
Expand Down Expand Up @@ -233,12 +233,12 @@ export class HoldRequest extends React.Component {
const bibLink =
bibId && title ? (
<h2>
<Link
<DSLink
id='item-link'
to={`${appConfig.baseUrl}/bib/${bibId}`}
href={`${appConfig.baseUrl}/bib/${bibId}`}
>
{title}
</Link>
</DSLink>
</h2>
) : null;
const callNo =
Expand Down
1 change: 0 additions & 1 deletion test/unit/HoldRequest.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ describe('HoldRequest', () => {

it('should display the item title.', () => {
const item = component.find('.item');
expect(item.find('#item-link')).to.have.length(2);
expect(item.find('#item-link').at(1).text()).to.equal('Harry Potter');
});

Expand Down

0 comments on commit 88eb06c

Please sign in to comment.