Skip to content

Commit

Permalink
Merge pull request #235 from NYPL/qa
Browse files Browse the repository at this point in the history
Release 0.1.19
  • Loading branch information
7emansell authored Nov 18, 2024
2 parents 16e96c3 + 69c44c5 commit 81a89aa
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 4 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## [0.1.19] 2024-11-18

## Updated

- Updated collection card urls to use uuid
- Moved `/divisions` and `/divisions/[slug]` from behind middleware, now accessible

## [0.1.18] 2024-11-18

## Updated

- Updated item card urls to use uuid
- Updated collection card urls to use legacy url

## [0.1.17] 2024-11-14

### Updated
Expand Down
3 changes: 1 addition & 2 deletions app/src/models/collectionCard.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// import { CollectionCardData } from "app/types/Collection";
import { imageURL } from "../utils/utils";
import { stringToSlug } from "../utils/utils";
import { parseBoolean } from "../utils/utils";

// TODO: Connect to typescript interface for CollectionCardData
Expand All @@ -16,7 +15,7 @@ export class CollectionCardModel {
constructor(data: any) {
this.uuid = data.uuid;
this.title = data.title;
this.url = data.url.replace("https://digitalcollections.nypl.org", "");
this.url = `/collections/${data.uuid}`;
this.imageID = data.image_id || data.imageID;
this.imageURL = imageURL(data.imageID, "full", "288,", "0");
this.numberOfDigitizedItems =
Expand Down
2 changes: 0 additions & 2 deletions middleware.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export const config = {
matcher: [
"/collections",
"/collections/:path*",
"/divisions",
"/divisions/:path*",
"/items/:path*",
"/search/:path*",
],
Expand Down

0 comments on commit 81a89aa

Please sign in to comment.