Skip to content

Commit

Permalink
Merge pull request #224 from NYPL/feature/DR-3274/fix-division-title
Browse files Browse the repository at this point in the history
fix division title on division landing pages
  • Loading branch information
avertrees authored Nov 8, 2024
2 parents 2a3e5ef + 568c88b commit 4c3a0ea
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Refactored Repo API handler with added timeout errors (DR-3251)
- Removed canonical tag to old DC (DR-3264)


### Fixed
- fixed division titles on division landing pages (DR-3274)

## [0.1.16] 2024-10-31

### Updated
Expand Down
7 changes: 3 additions & 4 deletions app/src/components/pages/divisionPage/divisionPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import React, { useEffect, useState, useRef } from "react";
import PageLayout from "../../pageLayout/pageLayout";
import { headerBreakpoints } from "../../../utils/breakpoints";
import { CardsGrid } from "../../grids/cardsGrid";
import { slugToString, totalNumPages } from "../../../utils/utils";
import { totalNumPages } from "../../../utils/utils";
import useBreakpoints from "../../../hooks/useBreakpoints";
import { DC_URL } from "@/src/config/constants";
import { Lane as DCLane } from "../../lane/lane";
Expand All @@ -25,7 +25,6 @@ import LaneLoading from "../../lane/laneLoading";
export default function DivisionPage({ data }: any) {
const params = useParams();
const slug = params.slug as string;
const title = slugToString(slug);
const pageName = `divisions|${slug}`;
const [isLoaded, setIsLoaded] = useState(false);

Expand Down Expand Up @@ -62,7 +61,7 @@ export default function DivisionPage({ data }: any) {
breadcrumbs={[
{ text: "Home", url: "/" },
{ text: "Divisions", url: "/divisions" },
{ text: `${title}`, url: `/divisions/${data.slug}` },
{ text: `${data.name}`, url: `/divisions/${data.slug}` },
]}
adobeAnalyticsPageName={pageName}
>
Expand All @@ -86,7 +85,7 @@ export default function DivisionPage({ data }: any) {
gap: "m",
}}
>
<Heading level="h1" text={title} subtitle={data.summary} />
<Heading level="h1" text={data.name} subtitle={data.summary} />
<Link
type="standalone"
target="_blank"
Expand Down
9 changes: 8 additions & 1 deletion public/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Updated

- Updated cards to use Next Image (DR-3056)
- Refactored Repo API handler with added timeout errors (DR-3251)
- Removed canonical tag to old DC (DR-3264)

## [0.1.16] 2024-10-31

### Updated

- Updated links in QA to point internally for reverse proxy (DR-3237)
- Updated how env vars are read for New Relic Browser implementation (DR-3235)
- Updated 500 and 404 error page designs, adding link to open feedback box (DR-3203)
- Refactored collections/items grid into one `CardsGrid` component (DR-3193)
- Updated 500 and 404 error page designs, adding link to open feedback box (DR-3203)

## [0.1.15] 2024-10-10

Expand Down

0 comments on commit 4c3a0ea

Please sign in to comment.