Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative import xformer triton depend fix #37

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Relative import xformer triton depend fix #37

merged 4 commits into from
Nov 24, 2024

Conversation

lawrence-cj
Copy link
Collaborator

  1. replace import * with specific package;
  2. add import check for xformers and triton;
  3. support F.scaled_dot_product_attention when xformers is not available;

lawrence-cj and others added 4 commits November 24, 2024 18:16
@lawrence-cj
1. xformer import logi update;
88b93c7 
2. changing all import * to specific package import

Signed-off-by: lawrence-cj <[email protected]>
@lawrence-cj
1. change all import * to specific package;
6265a23 
2. fix bugs
3. add `triton` and `xformers` checking into import_utils.py
@lawrence-cj
support F.scaled_dot_product_attention without xformers
cc5991b
@Lyken17 @lawrence-cj
pre-commit
e55cbc7 
Signed-off-by: lawrence-cj <[email protected]>
@lawrence-cj lawrence-cj force-pushed the relative_import_xformer_triton_depend_fix branch from 90d3727 to e55cbc7 Compare November 24, 2024 11:24
@lawrence-cj lawrence-cj merged commit fa267d5 into main Nov 24, 2024
2 checks passed
@lawrence-cj lawrence-cj mentioned this pull request Nov 24, 2024
Closed
@lawrence-cj lawrence-cj deleted the relative_import_xformer_triton_depend_fix branch November 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawrence-cj @Lyken17