Fix invalid capacity when getByteBufferView of 2G block
#32
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeynmann
changed the title
getByteBufferView of 2G block
Signed-off-by: zizhao <[email protected]>
jeynmann
force-pushed
the
pr_support_2g_block
branch
from
8efbc24 to
c78480b
Compare
petro-rudenko
approved these changes
Jan 15, 2024
|
Can you please rebase on master - i've fixed CI to run checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
capacityof DirectBuffer isinttype.getByteBufferViewof a 2G size block will result in overflow.How?
Use real message buffer size instead of block size.