Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce time-consuming of pre-merge #9887

Merged
merged 34 commits into from
Jan 4, 2024
Merged

Reduce time-consuming of pre-merge #9887

merged 34 commits into from
Jan 4, 2024

Conversation

YanxuanLiu
Copy link
Collaborator

@YanxuanLiu YanxuanLiu commented Nov 29, 2023 •
edited
Loading

fix #9789

  1. Removed build only steps in mvn_verify
  2. Move some tests from ci_2 scala_2.13 to mvn_verify

@YanxuanLiu
add mark
2d335d5 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
reset
bef78a0 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
skip build only version
06e149c 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu force-pushed the rebalance-premerge-time branch from abc4262 to 06e149c Compare November 29, 2023 15:29
@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
restore build only steps
d325d70 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu force-pushed the rebalance-premerge-time branch from 052efaf to 800b9fa Compare December 4, 2023 04:33
@YanxuanLiu
Copy link
Collaborator Author

build

@sameerz sameerz added the build Related to CI / CD or cleanly building label Dec 5, 2023
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
add pytest mark for sort
5ee3666 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu marked this pull request as ready for review December 20, 2023 06:10
@YanxuanLiu YanxuanLiu self-assigned this Dec 25, 2023
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu changed the title Rebalance time-consuming of ci1 and ci2 Reduce time-consuming of pre-merge Dec 28, 2023
@YanxuanLiu YanxuanLiu requested a review from yinqingh December 28, 2023 01:42
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu
Copy link
Collaborator Author

YanxuanLiu commented Jan 2, 2024 •
edited
Loading

Duration Compare:

  • mvn_verify: 2h47m -> 1h54m
  • ci_2: 3h26m -> 3h2m
  • scala2.13: 2h49m -> 2h10m

timezone tests in ci_2 take 20-30mins

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jan 2, 2024

Duration Compare:

  • mvn_verify: 2h47m -> 1h54m
  • ci_2: 3h26m -> 3h2m
  • scala2.13: 2h49m -> 2h10m

timezone tests in ci_2 take 20-30mins

Looks like the ci_2 is the bottle neck. We can consider move timezone tests out into mvn_verify from ci_2 to balance pre-merge time

@YanxuanLiu
Copy link
Collaborator Author

build

NvTimLiu
NvTimLiu approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@YanxuanLiu
Copy link
Collaborator Author

Duration Compare:

  • mvn_verify: 2h47m -> 1h54m
  • ci_2: 3h26m -> 3h2m
  • scala2.13: 2h49m -> 2h10m

timezone tests in ci_2 take 20-30mins

Looks like the ci_2 is the bottle neck. We can consider move timezone tests out into mvn_verify from ci_2 to balance pre-merge time

Moved timezone tests to mvn_verify

@YanxuanLiu YanxuanLiu merged commit 3f60308 into NVIDIA:branch-24.02 Jan 4, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryShen2008 GaryShen2008 GaryShen2008 left review comments

@NvTimLiu NvTimLiu NvTimLiu approved these changes

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@yinqingh yinqingh Awaiting requested review from yinqingh

Assignees

@YanxuanLiu YanxuanLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] rebalance premerge stages (verify + ci_2 + scala 213) to reduce job-level finish time
4 participants
@YanxuanLiu @NvTimLiu @GaryShen2008 @sameerz