Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_cast_string_date_valid_format generating year 0 #9871

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix test_cast_string_date_valid_format generating year 0 #9871

merged 1 commit into from
Nov 29, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 28, 2023

Fixes #9781. Updates the regular expression used in the test to avoid the possibility of generating a date with all zeroes.

@jlowe jlowe added the test Only impacts tests label Nov 28, 2023
@jlowe jlowe self-assigned this Nov 28, 2023
@jlowe jlowe changed the base branch from branch-24.02 to branch-23.12 November 28, 2023 15:55
@jlowe
Copy link
Member Author

jlowe commented Nov 28, 2023

build

@jlowe jlowe merged commit 3696563 into NVIDIA:branch-23.12 Nov 29, 2023
38 checks passed
@jlowe jlowe deleted the fix-string-date-format-test branch November 29, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] test_cast_string_date_valid_format fails on DATAGEN_SEED=1700250017
2 participants
@jlowe @revans2