[WIP] Move xfail to allow_non_gpu for non-UTC time zone. #9869
Conversation
Signed-off-by: Ferdinand Xu <[email protected]>
res-life
force-pushed
the
ferdinand_fine_grained
branch
from
abf5b61 to
8ce99fd
Compare
res-life
force-pushed
the
ferdinand_fine_grained
branch
from
8ce99fd to
778fa00
Compare
|
|
||
|
|
||
| # allow non gpu when time zone is non-UTC because of https://github.com/NVIDIA/spark-rapids/issues/9653' | ||
| non_utc_allow=['ProjectExec', 'FilterExec', 'FileSourceScanExec', 'BatchScanExec', 'CollectLimitExec', 'DeserializeToObjectExec', 'DataWritingCommandExec', 'WriteFilesExec'] if is_not_utc() else [] |
There was a problem hiding this comment.
FYI. ShuffleExchangeExec based on my local test.
res-life
force-pushed
the
ferdinand_fine_grained
branch
from
b6ad928 to
3f90a9d
Compare
|
@res-life can you please explain why you are making this change? I think it is to allow us to verify that we get the right answer instead of seeing data corruption. If so I am conflicted here. I like the idea of verifying that we got the right answer. But I don't like that this is done with one list of operators that are allowed to not be on the GPU for every test. Each test is unique and I get that you don't want to spend a ton of time to customize it per test. But if we don't look at each test and know what we expect to fall back how do we know that we are doing the right thing? I am not going to block this from going in, because I think it is better than what we have now. But I really would like to see a follow on issue to go back for all of the tests and customize it. |
res-life
force-pushed
the
ferdinand_fine_grained
branch
from
3f90a9d to
bb1cbca
Compare
res-life
force-pushed
the
ferdinand_fine_grained
branch
from
094c533 to
70c2167
Compare
This is based on #9719
This PR will be merged to #9719
It's here for review purpose.