-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support For Various Execs for Databricks 13.3 #9637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldest supported version
Signed-off-by: Raza Jafri <[email protected]>
sameerz
added
the
task
Work required that improves the product but is not user facing
label
Nov 6, 2023
jlowe
reviewed
Nov 6, 2023
...gin/src/main/spark321db/scala/org/apache/spark/rapids/shims/GpuShuffleExchangeExecBase.scala
Outdated
Show resolved
Hide resolved
...lugin/src/main/spark341db/scala/com/nvidia/spark/rapids/shims/PartitionedFileUtilsShim.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark341db/scala/org/apache/spark/rapids/shims/GpuShuffleExchangeExec.scala
Outdated
Show resolved
Hide resolved
...ugin/src/main/spark341db/scala/org/apache/spark/sql/hive/rapids/shims/FileSinkDescShim.scala
Outdated
Show resolved
Hide resolved
...in/src/main/spark341db/scala/org/apache/spark/sql/hive/rapids/shims/HiveInspectorsShim.scala
Outdated
Show resolved
Hide resolved
...c/main/spark341db/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala
Outdated
Show resolved
Hide resolved
jlowe
approved these changes
Nov 6, 2023
build |
1 similar comment
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces essential changes for adding compatibility for Databricks 13.3, specifically focusing on refactoring existing shims.
Changes Made:
getExistenceDefaultValues
method instead ofexistenceDefaultValues
array as it has been converted to an Option in the new Databricks version.test_multi_table_hash_join
test failureTesting
Tests will be added in future PR
fixes #9491
contributes towards 9175