Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-merge] branch-23.10 to branch-23.12 [skip ci] [bot] #9319

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

nvauto
Copy link
Collaborator

@nvauto nvauto commented Sep 28, 2023

auto-merge triggered by github actions on branch-23.10 to create a PR keeping branch-23.12 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

…ilter and GpuProject (#9287)

fix #7865

This PR is to support checkpoint and restore on non-deterministic expressions in GpuFilter and GpuProject.

1. Introduce a new interface named Retryable in Java to supprt Java UDF in the future for end users.
   A non-deterministic expression can implement this interface to make it retryable.
2. Introduce a new class named RapidsXORShiftRandom to provide access to the internal hashed seed.
    This is used by GpuRand to implement the Retryable interface.
3. Removed the useless CheckpointRestore trait, replaced by the new Retryable interface.
4. Update GpuRand to support checkpoint and restore.
5. Introduce two new memebers in GpuExpression, they are selfNonDeterministic and retryable. retryable
    is used to tell whether an expression is retryable. It will cover its children. While selfNonDeterministic
    indicates whether an expression itself is non-deterministic when its "deterministic" is false, excluding
    its children. An expression is actually a tree, and deterministic being false means there is at least one
    tree node is non-deterministic, but we need to know the exact nodes which are non-deterministic to 
    check if it implements the Retryable. So selfNonDeterministic is created.

---------

Signed-off-by: Firestarman <[email protected]>
@nvauto nvauto merged commit 6dcc63f into branch-23.12 Sep 28, 2023
@nvauto
Copy link
Collaborator Author

nvauto commented Sep 28, 2023

SUCCESS - auto-merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants