Stop double closing in json scan + skip test #8413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
|
build |
1 similar comment
|
build |
jlowe
reviewed
May 26, 2023
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
approved these changes
May 30, 2023
revans2
approved these changes
May 30, 2023
…into stop_double_closing_in_json_scan
…a/spark-rapids into stop_double_closing_in_json_scan
|
build |
gerashegalov
approved these changes
May 30, 2023
| @@ -436,6 +436,7 @@ def test_json_datetime_parsing_fallback_no_datetime(std_input_path, filename, sc | |||
| lambda spark : spark.read.schema(schema).option('enableDateTimeParsingFallback', "true").json(data_path), | |||
| conf=_enable_all_types_conf) | |||
|
|
|||
| @pytest.mark.skip(reason=str("https://github.com/NVIDIA/spark-rapids/issues/8403")) | |||
There was a problem hiding this comment.
nit: Other usages in our repo do not require str() conversion for a literal reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8411
Stops a double close on exception in
GpuJsonScan.Skips
test_read_case_col_namesdue to #8403, while we investigate further.