Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh pages branch 21.10 #3902

Merged
merged 9 commits into from
Oct 29, 2021
Merged

Gh pages branch 21.10 #3902

merged 9 commits into from
Oct 29, 2021

Conversation

nearodney
Copy link
Contributor

This is to fix gh-pages branch based on 21.10 doc.
This is the PR for documentation issue #3901 opened for gh-pages.

Here is the viewable gh-pages link for this change for review:
https://nearodney.github.io/spark-rapids/

Fixes #3901

@nearodney nearodney added the ? - Needs Triage Need team to review and classify label Oct 22, 2021
@nearodney nearodney added this to the Oct 18 - Oct 29 milestone Oct 22, 2021
@nearodney nearodney requested a review from viadea October 22, 2021 15:04
@viadea viadea requested a review from sameerz October 22, 2021 15:05
@nvliyuan
Copy link
Collaborator

should we rebase this pr to gh-pages after it merged?

@sameerz
Copy link
Collaborator

sameerz commented Oct 22, 2021

should we rebase this pr to gh-pages after it merged?

We can cherry pick 3858 on top of gh-pages once this goes in.

@sameerz sameerz added documentation Improvements or additions to documentation and removed ? - Needs Triage Need team to review and classify labels Oct 22, 2021
sameerz
sameerz requested changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating the FAQ.md question Which distributions are supported? to include AWS EMR 6.4 (or say 6.2+) and Cloudera CDP 7.1.6+.

docs/get-started/getting-started-on-prem.md Outdated Show resolved Hide resolved
docs/download.md Outdated Show resolved Hide resolved
docs/download.md Outdated Show resolved Hide resolved
@viadea
Copy link
Collaborator

viadea commented Oct 25, 2021

should we rebase this pr to gh-pages after it merged?

We can cherry pick 3858 on top of gh-pages once this goes in.

#3906 is filed for 21.10 branch update by @nvliyuan

@viadea viadea self-requested a review October 25, 2021 19:10
sameerz
sameerz approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please do not merge until the previous release steps are done per #3402

@viadea viadea mentioned this pull request Oct 25, 2021
Merged
@viadea viadea merged commit e37efc3 into NVIDIA:gh-pages Oct 29, 2021
@sameerz sameerz linked an issue Nov 3, 2021 that may be closed by this pull request
[DOC]Update gh-pages for 21.10 release #3901
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvliyuan nvliyuan nvliyuan left review comments

@viadea viadea viadea approved these changes

@sameerz sameerz sameerz approved these changes

Assignees

@viadea viadea

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Oct 18 - Oct 29
Development

Successfully merging this pull request may close these issues.

[DOC]Update gh-pages for 21.10 release
4 participants
@nearodney @nvliyuan @sameerz @viadea