Make sure that the chunked packer bounce buffer is realease after the synchronize #11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… synchronize Signed-off-by: Alessandro Bellina <[email protected]>
|
build |
revans2
reviewed
Dec 18, 2024
| @@ -1719,7 +1719,7 @@ class ChunkedPacker(table: Table, | |||
| } | |||
|
|
|||
| override def next(): (DeviceBounceBuffer, Long) = { | |||
| withResource(bounceBufferPool.nextBuffer()) { bounceBuffer => | |||
| closeOnExcept(bounceBufferPool.nextBuffer()) { bounceBuffer => | |||
There was a problem hiding this comment.
So just to confirm that the bounce buffer will be closed by the caller of next? I am just confused because that should have caused a double free of some kind because we closed it and then returned it.
There was a problem hiding this comment.
yeah this is DeviceBounceBuffer, it is not DeviceMemoryBuffer. I can add a throw in DeviceBounceBuffer if we unacquire too many times causing the double free. The bug is that it returns the buffer back to the pool and now it is eligible for the next write.. doing bad bad things.
There was a problem hiding this comment.
That is fine, it is just confusing that we only "fixed" one side of it.
revans2
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11885
The issue this fixes is that the bounce buffer seen here cannot be closed (released back to the pool) before the stream synchronize that happens at the caller of
.next. We need to return the bounce buffer and allow the caller to close, which can be done in the right order.