Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small improvements #11847

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Some small improvements #11847

merged 1 commit into from
Dec 11, 2024

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Dec 10, 2024 •
edited
Loading

This PR is addressing some issues found during my local split-retry triage, to try to improve the stability. So there is no issue for it.

It includes:

  • replacing map with safeMap for the conversion between Table and ColumnarBatch.
  • reducing the GPU peak memory by closing the unnecessary batches as soon as possbile in Generate exec.
  • adding the retry support for Table splitting operation in Gpu write.
  • eliminating a potential memory leak in BroadcastNestedLoop join.

The existing tests should already cover these changes.

@firestarman
Copy link
Collaborator Author

build

@firestarman firestarman merged commit 2999a14 into NVIDIA:branch-25.02 Dec 11, 2024
51 checks passed
@firestarman firestarman deleted the small-improvements branch December 11, 2024 01:45
@sameerz sameerz added the reliability Features to improve reliability or bugs that severly impact the reliability of the plugin label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellina abellina abellina approved these changes

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@firestarman @jlowe @abellina @sameerz