-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balance the pre-merge CI job's time for the ci_1 and ci_2 tests #11826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix: NVIDIA#11825 The pre-merge CI job is divided into CI_1 (mvn_verify) and CI_2. We run these two parts in parallel to speed up the pre-merge CI. Currently, CI_1 takes about 2 hours, while CI_2 takes approximately 4 hours. Mark some tests as CI_1 to balance the time between CI_1 and CI_2 After remarking tests, both CI_1 and CI_2 jobs should be finished in 3 hours or so. Signed-off-by: timl <[email protected]>
build |
To balance the duration, separate pre-merge CI job to two parts: premergeUT1(2 shims' UT + 1/3 of the integration tests) premergeUT2(1 shim's UT + 2/3 of the integration tests), for balancing the duration Signed-off-by: timl <[email protected]>
build |
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
gerashegalov
as code owners
December 6, 2024 02:15
pxLi
approved these changes
Dec 6, 2024
merged it to alleviate timeout issue for pre-merge CI, |
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this pull request
Dec 11, 2024
I've seen several cases of PRs timing out after 4 hours though we've done a re-balance for 25.02 recently NVIDIA#11826 We'll make additional efforts to balance the pre-merge CI's duration. Let's increase the timeout to 6 hours first. We'll continue to work on balancing the pre-merge CI's duration Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
added a commit
that referenced
this pull request
Dec 11, 2024
I've seen several cases of PRs timing out after 4 hours though we've done a re-balance for 25.02 recently #11826 We'll make additional efforts to balance the pre-merge CI's duration. Let's increase the timeout to 6 hours first. We'll continue to work on balancing the pre-merge CI's duration Signed-off-by: Tim Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #11825
The pre-merge CI job is divided into CI_1 (mvn_verify) and CI_2.
We run these two parts in parallel to speed up the pre-merge CI.
Currently, CI_1 takes about 2 hours, while CI_2 takes approximately 4 hours.
Mark some tests as CI_1 to balance the time between CI_1 and CI_2
After remarking tests, both CI_1 (2hours) and CI_2(4hours) jobs should be finished in
3 hours
or so. Details as below: