Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance the pre-merge CI job's time for the ci_1 and ci_2 tests #11826

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Dec 5, 2024

To fix: #11825

The pre-merge CI job is divided into CI_1 (mvn_verify) and CI_2.

We run these two parts in parallel to speed up the pre-merge CI.

Currently, CI_1 takes about 2 hours, while CI_2 takes approximately 4 hours.

Mark some tests as CI_1 to balance the time between CI_1 and CI_2

After remarking tests, both CI_1 (2hours) and CI_2(4hours) jobs should be finished in 3 hours or so. Details as below:

CI_1(mvn verify): 2.0h --> 3.0h
CI_2:             4.0h --> 2.5h
CI_Scala2.13       2.3h --> 2.8h

image

To fix: NVIDIA#11825

The pre-merge CI job is divided into CI_1 (mvn_verify) and CI_2.

We run these two parts in parallel to speed up the pre-merge CI.

Currently, CI_1 takes about 2 hours, while CI_2 takes approximately 4 hours.

Mark some tests as CI_1  to balance the time between CI_1 and CI_2

After remarking tests, both CI_1 and CI_2 jobs should be finished in 3 hours or so.

Signed-off-by: timl <[email protected]>
@NvTimLiu NvTimLiu self-assigned this Dec 5, 2024
@NvTimLiu NvTimLiu marked this pull request as draft December 5, 2024 08:23
@NvTimLiu NvTimLiu added build Related to CI / CD or cleanly building improve labels Dec 5, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Dec 5, 2024

build

To balance the duration, separate pre-merge CI job to two parts:
    premergeUT1(2 shims' UT + 1/3 of the integration tests)
    premergeUT2(1 shim's UT + 2/3 of the integration tests), for balancing the duration

Signed-off-by: timl <[email protected]>
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Dec 5, 2024

build

@NvTimLiu NvTimLiu marked this pull request as ready for review December 6, 2024 02:15
@nvauto
Copy link
Collaborator

nvauto commented Dec 6, 2024

merged it to alleviate timeout issue for pre-merge CI,
Tim Liu will follow it up if anything other concern/exception, thanks!

@nvauto nvauto merged commit 89984d0 into NVIDIA:branch-25.02 Dec 6, 2024
49 of 50 checks passed
NvTimLiu added a commit to NvTimLiu/spark-rapids that referenced this pull request Dec 11, 2024
I've seen several cases of PRs timing out after 4 hours though we've done a re-balance for 25.02 recently
NVIDIA#11826

We'll make additional efforts to balance the pre-merge CI's duration.

Let's increase the timeout to 6 hours first.

We'll continue to work on balancing the pre-merge CI's duration

Signed-off-by: Tim Liu <[email protected]>
NvTimLiu added a commit that referenced this pull request Dec 11, 2024
I've seen several cases of PRs timing out after 4 hours though we've done a re-balance for 25.02 recently
#11826

We'll make additional efforts to balance the pre-merge CI's duration.

Let's increase the timeout to 6 hours first.

We'll continue to work on balancing the pre-merge CI's duration

Signed-off-by: Tim Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants