Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable license header check #11786

Merged

Conversation

YanxuanLiu
Copy link
Collaborator

  1. Enable license header check Github workflow
  2. Add license header for files that are within the included scope and did not have a header before.

@YanxuanLiu
Copy link
Collaborator Author

build

1 similar comment
@YanxuanLiu
Copy link
Collaborator Author

build

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// automatically generated by the FlatBuffers compiler, do not modify
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I excluded all files in the format package in the script used to identify files with a missing copyright header in #11723.

Note, these files are generated by a manual flatc step. The source files do have a header

// Copyright (c) 2020-2024, NVIDIA CORPORATION.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset the changes of format/* files, and added an exclude pattern sql-plugin/src/main/java/com/nvidia/spark/rapids/format/* to workflow arguments.

@YanxuanLiu YanxuanLiu force-pushed the enable-license-header-check branch from 351f382 to 591f389 Compare December 2, 2024 05:12
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu requested a review from pxLi December 4, 2024 02:39
@YanxuanLiu
Copy link
Collaborator Author

Hi @gerashegalov , could you help to review the PR again? Thanks!

@gerashegalov gerashegalov self-requested a review December 4, 2024 17:47
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YanxuanLiu YanxuanLiu merged commit 7927ae9 into NVIDIA:branch-25.02 Dec 5, 2024
50 checks passed
@sameerz sameerz added build Related to CI / CD or cleanly building documentation Improvements or additions to documentation labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants