-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable license header check #11786
Enable license header check #11786
Conversation
YanxuanLiu
commented
Nov 27, 2024
- Enable license header check Github workflow
- Add license header for files that are within the included scope and did not have a header before.
build |
1 similar comment
build |
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// automatically generated by the FlatBuffers compiler, do not modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I excluded all files in the format
package in the script used to identify files with a missing copyright header in #11723.
Note, these files are generated by a manual flatc
step. The source files do have a header
spark-rapids/sql-plugin/src/main/format/ShuffleCommon.fbs
Lines 1 to 13 in 351f382
// Copyright (c) 2020-2024, NVIDIA CORPORATION. | |
// | |
// Licensed under the Apache License, Version 2.0 (the "License"); | |
// you may not use this file except in compliance with the License. | |
// You may obtain a copy of the License at | |
// | |
// http://www.apache.org/licenses/LICENSE-2.0 | |
// | |
// Unless required by applicable law or agreed to in writing, software | |
// distributed under the License is distributed on an "AS IS" BASIS, | |
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
// See the License for the specific language governing permissions and | |
// limitations under the License. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reset the changes of format/*
files, and added an exclude pattern sql-plugin/src/main/java/com/nvidia/spark/rapids/format/*
to workflow arguments.
Signed-off-by: YanxuanLiu <[email protected]>
351f382
to
591f389
Compare
build |
Hi @gerashegalov , could you help to review the PR again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM