Fix the task count check in TrafficController #11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
1 similar comment
|
build |
Signed-off-by: Jihoon Son <[email protected]>
jihoonson
force-pushed
the
fix-traffic-controller
branch
from
c64ee28 to
b4b56a0
Compare
|
build |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/io/async/TrafficController.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Gera Shegalov <[email protected]>
|
build |
gerashegalov
reviewed
Dec 2, 2024
sql-plugin/src/main/scala/com/nvidia/spark/rapids/io/async/TrafficController.scala
Show resolved
Hide resolved
revans2
reviewed
Dec 2, 2024
sql-plugin/src/main/scala/com/nvidia/spark/rapids/io/async/TrafficController.scala
Show resolved
Hide resolved
revans2
previously approved these changes
Dec 2, 2024
|
build |
|
@gerashegalov @revans2 would you please have another look? |
revans2
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #11730. If that is the only task at the moment, the
TrafficControllershould allow the task to process regardless of how much host memory it uses. However, this check was missing in the loop below, which would have all subsequent tasks hung if a task that uses a large memory is submitted while there are some tasks running.This PR fixes this bug. Additionally, it improves the
TrafficControllerto use the condition variable instead of polling as suggested in #11730 (comment). Finally, the terminology inThrottlingExecutorSuitehas been fixed as suggested in #11730 (comment).