Remove batch size bytes limits #11746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Puller <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
zpuller
commented
Nov 21, 2024
| @@ -223,8 +223,6 @@ case class RequireSingleBatchWithFilter(filterExpression: GpuExpression) | |||
| case class TargetSize(override val targetSizeBytes: Long) | |||
There was a problem hiding this comment.
not sure if we still need targetSizeBytes
There was a problem hiding this comment.
I think CoalesceSizeGoal still needs it
There was a problem hiding this comment.
Yes, we still need targetSizeBytes.
Signed-off-by: Zach Puller <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
abellina
approved these changes
Nov 22, 2024
|
build |
revans2
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with higher batch sizes has shown potential performance improvements in certain scenarios, and has not shown any evidence of query failures or data corruption, so we think we are comfortable removing the existing limits we've been imposing on these configs.