Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not package the Databricks 14.3 shim into the dist jar [skip ci] #11744

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Do not package the Databricks 14.3 shim into the dist jar [skip ci] #11744

merged 2 commits into from
Nov 22, 2024

Conversation

NvTimLiu
Copy link
Collaborator

The 350db143 shim will be packaged into the dist jar in branch-25.02

@NvTimLiu
Do not package the Databricks 14.3 shim into the dist jar
676c7c5 
The 350db143 shim will be packaged into the dist jar in branch-25.02

Signed-off-by: timl <[email protected]>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Nov 21, 2024
@NvTimLiu NvTimLiu self-assigned this Nov 21, 2024
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu
Copy link
Collaborator Author

Local test got PASS

source jenkins/version-def.sh
SPARK_SHIM_VERSIONS_DATABRICKS=330db 332db 341db
SPARK_SHIM_VERSIONS=320 321 321cdh 322 323 324 330 331 332 333 334 340 341 342 343 344 330cdh 332cdh 350 351 352 353
export SCALA_BINARY_VER=2.13

source jenkins/version-def.sh
SCALA_BINARY_VER: 2.13
SPARK_SHIM_VERSIONS_DATABRICKS=330db 332db 341db
SPARK_SHIM_VERSIONS=330 331 332 333 334 340 341 342 343 344 350 351 352 353 400

@gerashegalov gerashegalov mentioned this pull request Nov 21, 2024
Open
revans2
revans2 previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. It is minor because I don't think we will forget about it when we are ready to ship 14.3

pom.xml Outdated
@@ -813,7 +813,8 @@

<properties>
<!-- start dyn.shim properties -->
<dyn.shim.excluded.releases/>
<!-- TODO: will package 350db143 shim into the dist jar in branch-25.02 -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a URL for the follow on issue that is supposed to do this?

gerashegalov
gerashegalov previously approved these changes Nov 21, 2024
View reviewed changes
razajafri
razajafri reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I do think we should file a follow-on like @revans2 has suggested

@NvTimLiu NvTimLiu dismissed stale reviews from gerashegalov and revans2 via bf2bee1 November 22, 2024 01:57
@NvTimLiu
Copy link
Collaborator Author

[skip ci], pre-merge has been PASS in the previous commit, the latest commit only add a comment.

@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu NvTimLiu changed the title Do not package the Databricks 14.3 shim into the dist jar Do not package the Databricks 14.3 shim into the dist jar [skip test] Nov 22, 2024
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu NvTimLiu changed the title Do not package the Databricks 14.3 shim into the dist jar [skip test] Do not package the Databricks 14.3 shim into the dist jar [skip ci] Nov 22, 2024
@NvTimLiu
Copy link
Collaborator Author

build

@pxLi pxLi merged commit 7110cf4 into NVIDIA:branch-24.12 Nov 22, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razajafri razajafri razajafri left review comments

@pxLi pxLi pxLi approved these changes

@revans2 revans2 revans2 left review comments

@gerashegalov gerashegalov gerashegalov left review comments

@yinqingh yinqingh Awaiting requested review from yinqingh

@YanxuanLiu YanxuanLiu Awaiting requested review from YanxuanLiu

@jlowe jlowe Awaiting requested review from jlowe

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

Assignees

@NvTimLiu NvTimLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NvTimLiu @gerashegalov @revans2 @pxLi @razajafri