Add HiveHash support for nested types
#11660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ustcfy <[email protected]>
ustcfy
changed the title
HiveHash support for nested types
Signed-off-by: Yan Feng <[email protected]>
|
Looks good to me, but better have more looks at this. |
Signed-off-by: Yan Feng <[email protected]>
Signed-off-by: Yan Feng <[email protected]>
|
build |
firestarman
reviewed
Dec 5, 2024
| } | ||
| val maxDepth = a.children.map(c => getMaxNestedDepth(c.dataType)).max | ||
| if (maxDepth > 8) { | ||
| willNotWorkOnGpu(s"GPU HiveHash supports 8 levels at most for " + |
There was a problem hiding this comment.
Can we add a test for this fallback ?
There was a problem hiding this comment.
Nit: We should better retrieve this maxDepth from JNI instead, so if we change the max depth support in the future, we won't have to modify this code.
Check out the example this approach here:
ttnghia
reviewed
Dec 10, 2024
Comment on lines
3324
to
3325
| TypeSig.psNote(TypeEnum.ARRAY, "Nested levels exceeding 8 layers are not supported") + | ||
| TypeSig.psNote(TypeEnum.STRUCT, "Nested levels exceeding 8 layers are not supported"), |
There was a problem hiding this comment.
Don't explicitly say "8 layers" as this can be changed at anytime.
Signed-off-by: Yan Feng <[email protected]>
Signed-off-by: Yan Feng <[email protected]>
firestarman
approved these changes
Dec 13, 2024
ttnghia
approved these changes
Dec 13, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11674
This PR adds support for Hive hash with
structandlisttypes, and it depends on NVIDIA/spark-rapids-jni#2534