Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict with branch-24.10 #11579

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Oct 9, 2024

Fixes the merge conflict with branch-24.10 flagged by #11568. Merge conflicts were related to #11567 with the 24.12 versions being taken since they already had a superset of the changes.

NOTE: This needs to be merged with a merge commit, not squashed!

@jlowe jlowe added the build Related to CI / CD or cleanly building label Oct 9, 2024
@jlowe jlowe self-assigned this Oct 9, 2024
@jlowe
Copy link
Contributor Author

jlowe commented Oct 9, 2024

build

Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks the part, when diffing against branch-24.10.

LGTM.

@jlowe jlowe merged commit 025e62e into NVIDIA:branch-24.12 Oct 9, 2024
46 checks passed
@jlowe jlowe deleted the fixmerge branch October 9, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants