Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests after string_split was fixed [databricks] #11474

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Enable tests after string_split was fixed [databricks] #11474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c90f07
Enable cast_array_to_string and cast_map_to_string tests
revans2 Sep 16, 2024
21c6c13
Enable mortgage test again
revans2 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration_tests/src/main/python/cast_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ def _assert_cast_to_string_equal (data_gen, conf):
)


@pytest.mark.xfail(reason="https://github.com/NVIDIA/spark-rapids/issues/11437")
@pytest.mark.parametrize('data_gen', all_array_gens_for_cast_to_string, ids=idfn)
@pytest.mark.parametrize('legacy', ['true', 'false'])
@allow_non_gpu(*non_utc_allow)
Expand Down Expand Up @@ -358,7 +357,6 @@ def test_cast_array_with_unmatched_element_to_string(data_gen, legacy):
)


@pytest.mark.xfail(reason="https://github.com/NVIDIA/spark-rapids/issues/11437")
@pytest.mark.parametrize('data_gen', basic_map_gens_for_cast_to_string, ids=idfn)
@pytest.mark.parametrize('legacy', ['true', 'false'])
@allow_non_gpu(*non_utc_allow)
Expand Down
3 changes: 1 addition & 2 deletions ...tion_tests/src/test/scala/com/nvidia/spark/rapids/tests/mortgage/MortgageSparkSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ class MortgageSparkSuite extends AnyFunSuite {
builder.getOrCreate()
}

// test failing, tracked by https://github.com/NVIDIA/spark-rapids/issues/11436
ignore("extract mortgage data") {
test("extract mortgage data") {
val df = Run.csv(
session,
getClass.getClassLoader.getResource("Performance_2007Q3.txt_0").getPath,
Expand Down