Fixed some of the failing parquet_tests [databricks] #11429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
revans2
reviewed
Sep 6, 2024
| @@ -35,15 +35,19 @@ def read_parquet_df(data_path): | |||
| def read_parquet_sql(data_path): | |||
| return lambda spark : spark.sql('select * from parquet.`{}`'.format(data_path)) | |||
|
|
|||
| datetimeRebaseModeInWriteKey = 'spark.sql.legacy.parquet.datetimeRebaseModeInWrite' if is_before_spark_400() else 'spark.sql.parquet.datetimeRebaseModeInWrite' | |||
There was a problem hiding this comment.
All of the non-legacy versions of these configs appear to have been added in 3.0.0. Is there a reason we are not just switching over to using them instead?
| @@ -47,7 +47,7 @@ case class GpuBatchScanExec( | |||
| @transient override lazy val batch: Batch = if (scan == null) null else scan.toBatch | |||
| // TODO: unify the equal/hashCode implementation for all data source v2 query plans. | |||
| override def equals(other: Any): Boolean = other match { | |||
| case other: GpuBatchScanExec => | |||
| case other: BatchScanExec => | |||
There was a problem hiding this comment.
Why is this being changed? This is a GpuBatchScanExec. We don't want to be equal to non-GPU versions do we?
There was a problem hiding this comment.
Right. While debugging I wasn't sure what was causing a failure and looking at 330 shim I changed this and didn't change it back before submitting this PR.
I am adding that change to this PR as well.
revans2
approved these changes
Sep 6, 2024
|
build |
|
The failure in CI seems unrelated The test only reads a CSV, sorts it and does a row count. It passes locally |
|
build |
|
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes towards fixing #11024