-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conform dependency list in 341db to previous versions style [databricks] #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Puller <[email protected]>
zpuller
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
August 13, 2024 16:21
jlowe
changed the title
conform dependency list in 341db to previous versions style
conform dependency list in 341db to previous versions style [databricks]
Aug 13, 2024
jlowe
previously approved these changes
Aug 13, 2024
build |
Signed-off-by: Zach Puller <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
build |
jlowe
reviewed
Aug 14, 2024
Signed-off-by: Zach Puller <[email protected]>
build |
…s shims Signed-off-by: Zach Puller <[email protected]>
build |
1 similar comment
build |
jlowe
previously approved these changes
Aug 16, 2024
CI failure seems unrelated, rekicking. |
build |
I think there is a real error actually
|
…rk artifacts Signed-off-by: Zach Puller <[email protected]>
build |
…cts (again) Signed-off-by: Zach Puller <[email protected]>
build |
jlowe
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11300
Uses the pattern established in previous db shims for declaring dependencies in the pom into 341.
Relying on CI for relevant build/tests.