-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the mismatching default configs in integration tests #11283
Merged
jihoonson
merged 41 commits into
NVIDIA:branch-24.10
from
jihoonson:fix-it-test-defaults
Aug 15, 2024
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
e3d6bff
Add a new interface to retrieve all configs with their defaults; Add …
jihoonson e7f1ec5
address comments
jihoonson 37c0f92
missing version update in 2.13 pom
jihoonson 85f05f3
fix match arms
jihoonson 6ba7300
take the json file path as an input
jihoonson 8dbd354
add the new config file in the assembly
jihoonson cb88561
missing 2.13 change
jihoonson 3a26d15
use maven build directory var
jihoonson 5d59de7
revert unintended change
jihoonson a7a04d0
remove unnecessary clean
jihoonson a7b5062
Add a new interface to retrieve all configs with their defaults; Add …
jihoonson 4483745
address comments
jihoonson 52fce4c
missing version update in 2.13 pom
jihoonson 35735c3
fix match arms
jihoonson 9f9ef1e
take the json file path as an input
jihoonson d73581e
add the new config file in the assembly
jihoonson 99ea474
missing 2.13 change
jihoonson 519bb7d
use maven build directory var
jihoonson c3ec423
revert unintended change
jihoonson 076351c
remove unnecessary clean
jihoonson b02faa2
Add things in RapidsConf
jihoonson 4a3c862
missing change for 2.13
jihoonson 8a7f316
fix directory path for scala 2.13
jihoonson ddb145a
exclude jackson from spark-hive
jihoonson 0542fdf
missing change for 2.13
jihoonson dab6f76
exclude old jackson stuff from iceberg
jihoonson 49a63d6
copyrights
jihoonson 31306f5
antrun
jihoonson c02e1c4
fix config file path
jihoonson 229528f
Merge branch 'fix-it-test-defaults-4' into fix-it-test-defaults
jihoonson b04484a
move most dump changes to rapids conf
gerashegalov 3e59847
clean up after merge
jihoonson fa380fb
scala 2.13
jihoonson 64b58d9
more strict arg check
jihoonson f336839
unpack ambiguous string arguments
jihoonson c4ba1a2
allow legacy negative scale for decimals for some tests
jihoonson 45beca3
should fork for RapidsConf
jihoonson d45dd1e
remove System.exit() from RapidsConf.main()
jihoonson 951c5f3
missing change for scala 2.13
jihoonson ab5d8b4
Fix more tests to set configs
jihoonson 04d86b8
add back explicit configs
jihoonson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we end up not needing this #11283 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I'm not quite sure why it works. I can add those java options here just in case..