-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in the ability to fingerprint JSON columns [databricks] #11060
Conversation
@gerashegalov and @tgravescs can you help me out here with the build and let me know if I am seeing thing incorrectly? I am getting an error trying to use classes in the jackson-core dependency. I have verified that the classes I need are in jackson-core-.jar, but even though it should be on the classpath it appears not to be. But the pom.xml files are complicated and I am not 100% sure that it is on the classpath, as that is not in the logs for the build. When I look at the logs of databricks installing things I see jackson-core is being pulled in as jackson-databind.
but
and the contents of the jars are different. Is this a bug in our script or has databricks actually combined the jars together? |
spark-rapids/jenkins/databricks/install_deps.py Lines 118 to 119 in 900ae6f
|
… as jackson-core for databricks Signed-off-by: Robert (Bobby) Evans <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
It got past the build on databricks so that was the problem :) |
build |
Can this be marked as closing issue #11053 ? |
That is up to you on how you want to track it. I reverted the original patch so that might have fixed it. This puts the functionality back in, but "fixed" so that is fine too. |
…1060) Also fixed issue with databricks dependency not being what we said it was. Signed-off-by: Robert (Bobby) Evans <[email protected]>
This is the same as #11002 but it was reverted because it broke databricks