Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts in HostAllocSuite to avoid timeout failures on slow machines #10150

Merged
merged 2 commits into from
Jan 4, 2024
+6 −5
Merged

Increase timeouts in HostAllocSuite to avoid timeout failures on slow machines #10150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07df776
Increase timeouts in HostAllocSuite to avoid timeout failures on slow…
jbrennan333 Jan 3, 2024
a3dce75
update copyrights
jbrennan333 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sql-plugin/src/test/scala/com/nvidia/spark/rapids/HostAllocSuite.scala
View file
Open in desktop
jlowe marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, NVIDIA CORPORATION.
* Copyright (c) 2023-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -37,6 +37,7 @@ class HostAllocSuite extends AnyFunSuite with BeforeAndAfterEach with
BeforeAndAfterAll with TimeLimits {
private val sqlConf = new SQLConf()
private val rc = new RapidsConf(sqlConf)
private val timeoutMs = 10000

def setMockContext(taskAttemptId: Long): Unit = {
val context = mock[TaskContext]
Expand Down Expand Up @@ -128,7 +129,7 @@ class HostAllocSuite extends AnyFunSuite with BeforeAndAfterEach with

override def toString: String = s"INIT TASK $name TASK $taskId"
})
waitForStart.get(1000, TimeUnit.MILLISECONDS)
waitForStart.get(timeoutMs, TimeUnit.MILLISECONDS)
}

def done: Future[Void] = {
Expand Down Expand Up @@ -217,7 +218,7 @@ class HostAllocSuite extends AnyFunSuite with BeforeAndAfterEach with
var fc: Option[Future[Void]] = None

def waitForAlloc(): Unit = {
fb.get(1000, TimeUnit.MILLISECONDS)
fb.get(timeoutMs, TimeUnit.MILLISECONDS)
}

def assertAllocSize(expectedSize: Long): Unit = synchronized {
Expand All @@ -239,7 +240,7 @@ class HostAllocSuite extends AnyFunSuite with BeforeAndAfterEach with

def waitForSpillable(): Unit = {
if (fsb.isEmpty) makeSpillableOnThread()
fsb.get.get(1000, TimeUnit.MILLISECONDS)
fsb.get.get(timeoutMs, TimeUnit.MILLISECONDS)
}

def freeOnThread(): Unit = {
Expand All @@ -256,7 +257,7 @@ class HostAllocSuite extends AnyFunSuite with BeforeAndAfterEach with

def waitForFree(): Unit = {
if (fc.isEmpty) freeOnThread()
fc.get.get(1000, TimeUnit.MILLISECONDS)
fc.get.get(timeoutMs, TimeUnit.MILLISECONDS)
}

def freeAndWait(): Unit = {
Expand Down