Fix test_window_aggs_for_batched_finite_row_windows_partitioned fail
#10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure. Fixes NVIDIA#10134. This commit fixes test failures in `test_window_aggs_for_batched_finite_row_windows_partitioned`, resulting from ambiguous ordering in the window function input. The failing tests partition by `a`, and order by `b,c`. When the values of `b,c` have repeated values, the results from the window function execution is indeterminate. This commit changes the definition of the aggregation column `c` (that's also included in the order-by clause), to use unique long values. This guarantees deterministic output. Signed-off-by: MithunR <[email protected]>
|
Build |
jlowe
approved these changes
Jan 3, 2024
|
@mythrocks are there major performance issues with these tests? CI timed out, and I see a huge time gap while running what looks like related tests. From the premerge log: |
|
No, no performance issues of which I'm aware. I'll double-check locally. Edit: These both run end-to-end in about 20 seconds locally. |
|
Build |
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this pull request
Jan 16, 2024
Fixes NVIDIA#10195. This is similar to the fix in NVIDIA#10143. This commit changes the test datagens used in the window function tests such that the order-by columns produce deterministic ordering. When the ordering is ambiguous, it can produce unexpected results from window functions, if the `order-by` spec includes the ambiguous columns. Signed-off-by: MithunR <[email protected]>
mythrocks
added a commit
that referenced
this pull request
Jan 18, 2024
Fixes #10195. This is similar to the fix in #10143. This commit changes the test datagens used in the window function tests such that the order-by columns produce deterministic ordering. When the ordering is ambiguous, it can produce unexpected results from window functions, if the `order-by` spec includes the ambiguous columns. Signed-off-by: MithunR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10134.
This commit fixes test failures in
test_window_aggs_for_batched_finite_row_windows_partitioned, resulting from ambiguous ordering in the window function input.The failing tests partition by
a, and order byb,c. When the values ofb,chave repeated values, the results from the window function execution is indeterminate.This commit changes the definition of the aggregation column
c(that's also included in the order-by clause), to use unique long values. This guarantees deterministic output.