[DOC] Add in docs about memory debugging [skip ci] #10104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
jbrennan333
previously approved these changes
Dec 28, 2023
docs/dev/README.md
Outdated
| @@ -241,6 +242,11 @@ port 5005. | |||
|
|
|||
| You can also use [Compute Sanitizer](compute_sanitizer.md) to debug CUDA memory errors. | |||
|
|
|||
| ### Memory Debugging | |||
| Java's garbage collector does not play nicely with CUDA memory allocations or with off heap memory. | |||
| There are a number of tools that we have developed that can help do | |||
There was a problem hiding this comment.
Suggested change
| There are a number of tools that we have developed that can help do | |
| There are a number of tools that we have developed that can help to |
docs/dev/mem_debug.md
Outdated
| close to the actual allocator as possible. But just be careful. | ||
|
|
||
| Also know that the address here should correspond to the address in the leak debugging if and only | ||
| if it was a DeviceMemoryBuffer that was allocated. In this case, where it is a `cudf::column` the |
There was a problem hiding this comment.
Suggested change
| if it was a DeviceMemoryBuffer that was allocated. In this case, where it is a `cudf::column` the | |
| if it was a `DeviceMemoryBuffer` that was allocated. In this case, where it is a `cudf::column` the |
docs/dev/mem_debug.md
Outdated
|
|
||
| We also don't have a way to | ||
| [log exactly what was spilled](https://github.com/NVIDIA/spark-rapids/issues/10103) | ||
| and what was read back it. We can probably guess that this is happening from other logs, but it |
There was a problem hiding this comment.
Suggested change
| and what was read back it. We can probably guess that this is happening from other logs, but it | |
| and what was read back. We can probably guess that this is happening from other logs, but it |
|
@jbrennan333 please take another look |
|
build |
jbrennan333
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9987
any feedback is appreciated.