Shim MockTaskContext to fix Spark 3.5.1 build #10096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
jlowe
added
test
|
build |
revans2
approved these changes
Dec 26, 2023
razajafri
approved these changes
Dec 26, 2023
| @@ -29,7 +29,7 @@ import org.apache.spark.scheduler.TaskLocality | |||
| import org.apache.spark.shuffle.FetchFailedException | |||
| import org.apache.spark.util.{AccumulatorV2, TaskCompletionListener, TaskFailureListener} | |||
|
|
|||
| class MockTaskContext(taskAttemptId: Long, partitionId: Int) extends TaskContext { | |||
There was a problem hiding this comment.
When there is just a new method that has not been used previously, we do not really have to fork the implementation into two shims as long as we do not insist on using the override keyword.
class MockTaskContext(taskAttemptId: Long, partitionId: Int) extends TaskContext {
def isFailed(): Boolean = false
}
razajafri
added a commit
to razajafri/spark-rapids
that referenced
this pull request
Dec 28, 2023
This reverts commit bc79bcf.
gerashegalov
pushed a commit
that referenced
this pull request
Dec 29, 2023
…ala [databricks] (#10106) * Revert "Shim MockTaskContext to fix Spark 3.5.1 build (#10096)" This reverts commit bc79bcf. * Added isFailed to MockTaskContext * Signing off Signed-off-by: Raza Jafri <[email protected]> --------- Signed-off-by: Raza Jafri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10094. Spark 3.5.1 incorporates SPARK-46480 which adds a new
isFailedmethod to the abstract TaskContext class. A new MockTaskContextBase shim is used to override this new method on Spark 3.5.1.