-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spark 3.3.4 Shim #10082
Add Spark 3.3.4 Shim #10082
Conversation
Signed-off-by: Raza Jafri <[email protected]>
The following tests were failing but I fixed them by pulling in changes from #9962 This may cause a merge conflict depending on what gets checked in first
|
build |
1 similar comment
build |
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace nits, lgtm.
@@ -14,6 +14,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace-only change to this file?
@@ -14,6 +14,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace-only change to this file?
@@ -14,6 +14,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace-only change to this file?
Thanks for the review @jlowe I will push a separate PR for the whitespace nits as the CI has passed. |
The point of the comment was to reduce unnecessary file churn by needlessly touching a file. Pushing out the fix for that to a separate PR misses the point and increases the unnecessary file churn. I was fine with it going unfixed as it's pretty minor, not sure it needs to be cleaned up now that it's been done. |
This PR adds shims for Spark 3.3.4
Changes Made:
mvn generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.overwrite=true -Dshimplify.add.shim=334 -Dshimplify.add.base=333
Tests:
All IT tests were run
fixed #9096