Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
Signed-off-by: Zach Puller <[email protected]>
  • Loading branch information
zpuller committed Jan 14, 2025
1 parent 5b399bd commit d82890d
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ trait SpillableHandle extends StoreHandle {
* thread will win and perform the spilling, and the other thread will make
* no modification.
*
* If the disk is full, or a spill failure occurs otherwise (eg. device issues),
* we make no attempt to handle it or restore state, as we expect to be in a non-recoverable
* state at the task/executor level.
*
* @note The size returned from this method is only used by the spill framework
* to track the approximate size. It should just return `approxSizeInBytes`, as
* that's the size that it used when it first started tracking the object.
Expand Down

0 comments on commit d82890d

Please sign in to comment.