Skip to content

Commit

Permalink
Disable regex tests to unblock CI (#11606)
Browse files Browse the repository at this point in the history
* xfail regexp tests to unblock CI

Signed-off-by: Jason Lowe <[email protected]>

* Disable failing regexp unit test to unblock CI

---------

Signed-off-by: Jason Lowe <[email protected]>
  • Loading branch information
jlowe authored Oct 14, 2024
1 parent 8c55ef3 commit 2d3e0ec
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 9 deletions.
3 changes: 3 additions & 0 deletions integration_tests/src/main/python/regexp_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ def test_re_replace():

# We have shims to support empty strings for zero-repetition patterns
# See https://github.com/NVIDIA/spark-rapids/issues/5456
@pytest.mark.xfail(reason="https://github.com/NVIDIA/spark-rapids/issues/11600")
def test_re_replace_repetition():
gen = mk_str_gen('.{0,5}TEST[\ud720 A]{0,5}')
assert_gpu_and_cpu_are_equal_collect(
Expand Down Expand Up @@ -698,6 +699,7 @@ def test_regexp_octal_digits():
),
conf=_regexp_conf)

@pytest.mark.xfail(reason="https://github.com/NVIDIA/spark-rapids/issues/11600")
def test_regexp_replace_digit():
gen = mk_str_gen('[a-z]{0,2}[0-9]{0,2}') \
.with_special_case('䤫畍킱곂⬡❽ࢅ獰᳌蛫青') \
Expand Down Expand Up @@ -1076,6 +1078,7 @@ def test_regexp_memory_fallback():
}
)

@pytest.mark.xfail(reason="https://github.com/NVIDIA/spark-rapids/issues/11600")
def test_regexp_memory_ok():
gen = StringGen('test')
assert_gpu_and_cpu_are_equal_collect(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ class RegularExpressionTranspilerSuite extends AnyFunSuite {

}

test("replace_replace - ?, *, +, and {0, n} repetitions") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("replace_replace - ?, *, +, and {0, n} repetitions") {
val patterns = Seq("D?", "D*", "D+", "D{0,}", "D{0,1}", "D{0,5}", "[1a-zA-Z]{0,}",
"[1a-zA-Z]{0,2}", "A+")
val inputs = Seq("SS", "DD", "SDSDSDS", "DDDD", "DDDDDD", "ABCDEFG")
Expand Down Expand Up @@ -710,23 +711,27 @@ class RegularExpressionTranspilerSuite extends AnyFunSuite {
}
}

test("AST fuzz test - regexp_find") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("AST fuzz test - regexp_find") {
doAstFuzzTest(Some(REGEXP_LIMITED_CHARS_FIND), REGEXP_LIMITED_CHARS_FIND,
RegexFindMode)
}

test("AST fuzz test - regexp_replace") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("AST fuzz test - regexp_replace") {
doAstFuzzTest(Some(REGEXP_LIMITED_CHARS_REPLACE), REGEXP_LIMITED_CHARS_REPLACE,
RegexReplaceMode)
}

test("AST fuzz test - regexp_find - full unicode input") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("AST fuzz test - regexp_find - full unicode input") {
assume(isUnicodeEnabled())
doAstFuzzTest(None, REGEXP_LIMITED_CHARS_REPLACE,
RegexFindMode)
}

test("AST fuzz test - regexp_replace - full unicode input") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("AST fuzz test - regexp_replace - full unicode input") {
assume(isUnicodeEnabled())
doAstFuzzTest(None, REGEXP_LIMITED_CHARS_REPLACE,
RegexReplaceMode)
Expand All @@ -736,7 +741,8 @@ class RegularExpressionTranspilerSuite extends AnyFunSuite {
Charset.defaultCharset().name() == "UTF-8"
}

test("AST fuzz test - regexp_find - anchor focused") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("AST fuzz test - regexp_find - anchor focused") {
doAstFuzzTest(validDataChars = Some("\r\nabc"),
validPatternChars = "^$\\AZz\r\n()[]-", mode = RegexFindMode)
}
Expand Down Expand Up @@ -778,7 +784,8 @@ class RegularExpressionTranspilerSuite extends AnyFunSuite {
}
}

test("regexp_split - repetition with {0,n}, or {0,}") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("regexp_split - repetition with {0,n}, or {0,}") {
// see https://github.com/NVIDIA/spark-rapids/issues/6958
val patterns = Set("ba{0,}", raw"a\02{0,}", "ba{0,2}", raw"b\02{0,10}")
val data = Seq("abaa", "baba", "ba\u0002b", "ab\u0002b\u0002a")
Expand Down Expand Up @@ -832,15 +839,17 @@ class RegularExpressionTranspilerSuite extends AnyFunSuite {
}
}

test("string split fuzz") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("string split fuzz") {
val (data, patterns) = generateDataAndPatterns(Some(REGEXP_LIMITED_CHARS_REPLACE),
REGEXP_LIMITED_CHARS_REPLACE, RegexSplitMode)
for (limit <- Seq(-2, -1, 2, 5)) {
doStringSplitTest(patterns, data, limit)
}
}

test("string split fuzz - anchor focused") {
// Disabling until https://github.com/NVIDIA/spark-rapids/issues/11600 is fixed
ignore("string split fuzz - anchor focused") {
val (data, patterns) = generateDataAndPatterns(validDataChars = Some("\r\nabc"),
validPatternChars = "^$\\AZz\r\n()", RegexSplitMode)
doStringSplitTest(patterns, data, -1)
Expand Down

0 comments on commit 2d3e0ec

Please sign in to comment.