Sync up supported ops for 24.02 plugin release #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amahussein
added
bug
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#795, Fixes NVIDIA#721, Fixes NVIDIA#712 This code change is to sync the supported-ops in the tools with the Plugin release 24.02.0 in addition to disabling `JsonTuple`
amahussein
force-pushed
the
spark-rapids-tools-795
branch
from
e2ac6f6 to
0f3be9d
Compare
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
|
@kuhushukla this includes fix for
|
amahussein
commented
Feb 22, 2024
| JsonTuple,S,`json_tuple`,None,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA | ||
| JsonToStructs,NS,`from_json`,This is disabled by default because it is currently in beta and undergoes continuous enhancements. Please consult the [compatibility documentation](../compatibility.md#json-supporting-types) to determine whether you can enable this configuration for your use case,project,jsonStr,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA | ||
| JsonToStructs,NS,`from_json`,This is disabled by default because it is currently in beta and undergoes continuous enhancements. Please consult the [compatibility documentation](../compatibility.md#json-supporting-types) to determine whether you can enable this configuration for your use case,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NS,PS,PS,NA | ||
| JsonTuple,NS,`json_tuple`,This is disabled by default because JsonTuple on the GPU does not support all of the normalization that the CPU supports.,project,json,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA |
There was a problem hiding this comment.
@mattahrens FYI, the plugin release 24.02.0 has JsonTuple enabled by default. @viadea asked to disable JsonTuple to match the changes in RAPIDS branch-24.04.0.
| if (shouldIgnore) { | ||
| OpActions.IgnorePerf | ||
| } else if (shouldRemove) { | ||
| // shouldRemove is checked first because sometimes an exec could have both flag set to true, |
There was a problem hiding this comment.
This is a quick fix for a discrepancy I found in the reporting. It had no affect on the accuracy of the results.
Some execs might have both flags set to True. In that case, "NoPerf" should take precedence.
| @@ -867,7 +867,7 @@ class SQLPlanParserSuite extends BaseTestSuite { | |||
| } | |||
| } | |||
|
|
|||
| test("json_tuple is supported in Generate") { | |||
| ignore("json_tuple is supported in Generate: disabled as the operator is disabled by default") { | |||
There was a problem hiding this comment.
Disable this unit-test because the JsonTuple is not supported anymore. We do not want to remove the unit-test since this is a temporarily change.
mattahrens
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #795, Fixes #721, Fixes #712
This code change is to sync the supported-ops in the tools with the Plugin release 24.02.0 in addition to disabling
JsonTuple