Profiler may crash if driverLog is not accessible #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amahussein
added
feature request
kuhushukla
commented
Jan 16, 2024
| import com.nvidia.spark.rapids.tool.EventLogPathProcessor | ||
|
|
||
| import org.apache.spark.internal.Logging | ||
| import org.apache.spark.sql.rapids.tool.AppFilterImpl | ||
| import org.apache.spark.sql.rapids.tool.util.RapidsToolsConfUtil | ||
|
|
||
|
|
Signed-off-by: Kuhu Shukla <[email protected]>
parthosa
reviewed
Jan 18, 2024
| @@ -78,7 +80,15 @@ object ProfileMain extends Logging { | |||
|
|
|||
| val profiler = new Profiler(hadoopConf, appArgs, enablePB) | |||
| if (driverLog.nonEmpty) { | |||
| profiler.profileDriver(driverLog, eventLogFsFiltered.isEmpty) | |||
| val dLogPath = new org.apache.hadoop.fs.Path(driverLog) | |||
There was a problem hiding this comment.
@amahussein Regarding the comment in issue description,
Furthermore, the class is not using hadoop API to load the files, which means that only files on local path can be processed.
Is this referring to the use case when the driver logs can be located in cloud storage directories (s3, dbfs), similar to what we have for event logs?
In that case, we might have to use a similar approach as processing event logs
There was a problem hiding this comment.
Yes, this is exactly what this issue is about.
It does not make sense to me that we process eventlogs on remote storage but we are asking the user to download the driver-logs locally.
|
Closing this PR as it became out dated it was not tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698