-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of HiveTableScan and InsertIntoHive text-format #723
Conversation
Fixes NVIDIA#681 - Add unit-test to support scan-hive-text - The check for the SerDe class to determine if the Hive format is supported or not - Only text-hive is supported for now. - Updated the read-format to include the ScanHive operations. - Added support to NativeScan as an alternative to the "Node Scan" Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein ! Overall LGTM. Just a few nits.
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/HiveParseHelper.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/AppBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/HiveParseHelper.scala
Show resolved
Hide resolved
Thanks @amahussein for this change. Could we have a demo or brief walkthrough for this as I am not very familiar with Hive and would like to know more? |
Fixes #681