Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with JDK11 #720

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

amahussein
Copy link
Collaborator

Fixes #717

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
@amahussein amahussein added bug Something isn't working core_tools Scope the core module (scala) labels Jan 8, 2024
@amahussein amahussein self-assigned this Jan 8, 2024
@amahussein amahussein requested review from parthosa and nartal1 January 8, 2024 22:16
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to update documentation about JDK11 support?

@amahussein
Copy link
Collaborator Author

LGTM. Do we need to update documentation about JDK11 support?

In the new documentation version. It is mentioned that Java8+ is supported.
So, we should be good

@amahussein amahussein merged commit 2883413 into NVIDIA:dev Jan 9, 2024
14 checks passed
@amahussein amahussein deleted the spark-rapids-tools-717 branch January 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compile error: ambiguous reference to overloaded definition
2 participants