Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling maven-metadata.xml to pull the latest tools jar #703

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #702

This PR is an alternative implementation to pull the latest version of the Tools jar.
The python module parses the maven-metadata.xml to get the available releases. It was found that this file is usually up-to-date with the releases.

  • Move some utility functions to the new package
  • Fix the logging message of the python module to avoid confusing RAPIDS jars with Tools jars

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#702

This PR is an alternative implementation to pull the latest version of
the Tools jar.
The python module parses the maven-metadata.xml to get the available
releases. It was found that this file is usually up-to-date with the
releases.

* Move some utility functions to the new package
* Fix the logging message of the python module to avoid confusing RAPIDS
  jars with Tools jars
@amahussein amahussein added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Dec 26, 2023
@amahussein amahussein self-assigned this Dec 26, 2023
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
@amahussein amahussein added the bug Something isn't working label Dec 26, 2023
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amahussein amahussein merged commit 69875a1 into NVIDIA:dev Dec 26, 2023
9 checks passed
@amahussein amahussein deleted the spark-rapids-tools-702 branch December 26, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fetching Jars from MVN may not return the latest version
3 participants