-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualification tool: Add more information for unsupported operators #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
added
feature request
New feature or request
core_tools
Scope the core module (scala)
labels
Dec 7, 2023
nartal1
requested review from
mattahrens,
viadea,
parthosa and
cindyyuanjiang
December 7, 2023 01:12
parthosa
reviewed
Dec 7, 2023
core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualOutputWriter.scala
Show resolved
Hide resolved
parthosa
reviewed
Dec 7, 2023
core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualOutputWriter.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Outdated
Show resolved
Hide resolved
…portedOperators_info
…portedOperators_info
parthosa
previously approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1.
amahussein
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #626 and fixes #656
In 626 - Output file had duplicate values once for Exec and another for Expressions.
This PR deduplicates the Exec in output files. i.e if an Exec is not supported due to unsupported expressions, then output will contain Exec name along with unsupported expressions. This PR also identifies UDF and dataset operations and includes that as the reason for the unsupported Exec. Also adds a new column "Ignore Operator" which indicates whether the operator is something like a DDL, Table operation which can be ignored. This helps to make sure we document all the unsupported operators in the output file but we can filter the operators to be prioritized based on "Ignore Operator" column.
Sample Output:
For 656 - Generates new output file (rapids_4_spark_qualification_output_unsupportedOperatorsStageDuration.csv) based on comment - #656 (comment) . This file helps to determine wallclockStageDuration to appDuration ratio and corresponding unsupported operators in that stage. This helps in prioritizing the unsupported opeators.
Sample output: