Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs with user tools and jar version details #642

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

parthosa
Copy link
Collaborator

Fixes #627. This PR adds version number for both user tools and jar in logs.

Testing:

Input Command

ascli qualification --eventlogs ~/work/test-event.log --verbose

Output

...
2023-10-30 16:45:14,616 INFO spark_rapids_tools.argparser: Cost saving is disabled: Platform [onprem] requires "target_platform" argument to generate cost savings
2023-10-30 16:45:14,617 INFO rapids.tools.qualification: Using Spark RAPIDS user tools version 23.10.1
2023-10-30 16:45:14,617 INFO rapids.tools.qualification: ******* [Initialization]: Starting *******
...
2023-10-30 16:45:14,891 INFO rapids.tools.qualification: RAPIDS accelerator jar is downloaded to work_dir /home/psarthi/work_dir/rapids-4-spark-tools_2.12-23.10.0.jar
2023-10-30 16:45:14,891 INFO rapids.tools.qualification: Using Spark RAPIDS accelerator jar version 23.10.0
2023-10-30 16:45:14,892 INFO rapids.tools.qualification: Checking dependency Apache Spark
...

Note - JAR version can be different from user tools if building from source on a development branch.

@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Oct 30, 2023
@parthosa parthosa self-assigned this Oct 30, 2023
@parthosa parthosa merged commit defd16c into NVIDIA:dev Oct 31, 2023
9 checks passed
@parthosa parthosa deleted the spark-rapids-tools-627 branch October 31, 2023 17:56
@parthosa parthosa added the feature request New feature or request label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Version number in log files
3 participants