Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling tool : Update readSchema string parser #635

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Oct 27, 2023

This fixes a bug where the readSchema in the eventlog has some characters before the string "...".
Example:
If the eventlog has an entry of trimmed string of node such as:

name_26:string,name_30:string,name_27:string,name_31:string,m...

And the ReadSchema is:

name_26:string,name_30:string,name_27:string,name_31:string,name_29:string,name_24:string,name_28:string,name_35:string,name_33:string,name_32:string,name_34:string,name_36:string,name_41:bigint,name_39:bigint,totalmatchscore:bigint,name_42:bigint,name_38:bigint,name_40:bigint,name_52:bigint

This PR trims all the characters from the last comma until "..."

@nartal1 nartal1 added bug Something isn't working core_tools Scope the core module (scala) labels Oct 27, 2023
@nartal1 nartal1 requested a review from mattahrens October 27, 2023 01:12
@nartal1 nartal1 self-assigned this Oct 27, 2023
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1. LGTM.

@nartal1 nartal1 merged commit 1a4756d into NVIDIA:dev Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants