Include expression parsers for HashAggregate and ObjectHashAggregate #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
added
bug
amahussein
reviewed
Nov 22, 2024
| @@ -59,7 +59,7 @@ class GenericExecParser( | |||
| } | |||
|
|
|||
| protected def getExprString: String = { | |||
| node.desc.replaceFirst(s"${node.name} ", "") | |||
| node.desc.replaceFirst(s"${node.name}\\s*", "") | |||
There was a problem hiding this comment.
Yeah I remember seeing HashAggregate( in the description
QQ: Is it possible that the node.name may not come at the beginning of the node description?
In that case we better use a regex ^(node_name)\\s* to guarantee that we replace node_name when it is at the beginning of the description.
There was a problem hiding this comment.
Thanks @amahussein ! Updated it. Adding of expression parsers was missed during refactoring. Since we are getting the expressions in #1431, we should be able to update some of the tests to capture these kinds of bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix. This was missed while refactoring Exec Parser PR - #1396
Changes in this PR :