Remove custom-speedup module from user-tools #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Contributes to NVIDIA#1221 This PR remove the python scripts that used to generate custom speedup factors. The scripts are dead since the tools migrated to XGBoost estimates.
amahussein
added
the
user_tools
mattahrens
approved these changes
Nov 15, 2024
|
Approved, but one question -- is the custom speedup factor file option being removed by another PR? https://github.com/NVIDIA/spark-rapids-tools/blob/dev/core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala#L184-L188 |
amahussein
deleted the
rapids-tools-1221-remove-custom-speedup-engine
branch
Yes, there is another task to remove deadcode from scala #1343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Contributes to #1221
This PR remove the python scripts that used to generate custom speedup factors. The scripts are dead since the tools migrated to XGBoost estimates.