-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing autotuner memory error to warning in comments #1418
Merged
mattahrens
merged 3 commits into
NVIDIA:dev
from
mattahrens:mahrens-tuner-memory-warning-1314
Nov 14, 2024
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -539,12 +539,12 @@ class AutoTuner( | |
// For now just throw so we don't get any tunings and its obvious to user this isn't a good | ||
// setup. In the future we may just recommend them to use larger nodes. This would be more | ||
// ideal once we hook up actual executor heap from an eventlog vs what user passes in. | ||
throwNotEnoughMemException(minExecHeapMem + minOverhead) | ||
warnNotEnoughMem(minExecHeapMem + minOverhead) | ||
(0, 0, 0, false) | ||
} else { | ||
val leftOverMemUsingMinHeap = containerMem - minExecHeapMem | ||
if (leftOverMemUsingMinHeap < 0) { | ||
throwNotEnoughMemException(minExecHeapMem + minOverhead) | ||
warnNotEnoughMem(minExecHeapMem + minOverhead) | ||
} | ||
// Pinned memory uses any unused space up to 4GB. Spill memory is same size as pinned. | ||
val pinnedMem = Math.min(MAX_PINNED_MEMORY_MB, (leftOverMemUsingMinHeap / 2)).toLong | ||
|
@@ -556,13 +556,12 @@ class AutoTuner( | |
} | ||
} | ||
|
||
private def throwNotEnoughMemException(minSize: Long): Unit = { | ||
private def warnNotEnoughMem(minSize: Long): Unit = { | ||
// in the future it would be nice to enhance the error message with a recommendation of size | ||
val msg = "This node/worker configuration is not ideal for using the Spark Rapids " + | ||
"Accelerator because it doesn't have enough memory for the executors. " + | ||
val msg = "This node/worker configuration is not ideal for using the Spark Rapids \n" + | ||
"Accelerator because it doesn't have enough memory for the executors. \n" + | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: trailing space before the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated in latest commit |
||
s"We recommend using nodes/workers with more memory. Need at least ${minSize}MB memory." | ||
logError(msg) | ||
throw new IllegalArgumentException(msg) | ||
appendComment(msg) | ||
} | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: trailing space before the
\n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in latest commit