Add support for disk spill metrics in Photon jobs #1405
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #251
Following up on #1390, this PR adds parsing for Disk Spill Size metrics for Photon Jobs.
"num bytes spilled to disk"
.in-memory
spills in Photon event logs.Changes
Enhancements to Photon-specific metrics handling:
core/src/main/scala/com/nvidia/spark/rapids/tool/analysis/AppSparkMetricsAnalyzer.scala
: Use aHashMap
to storeMetric -> Accumulator
and added support for disk spill size metrics. [1] [2]core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/DatabricksParseHelper.scala
: Added a new label for disk spill size metrics.Test expectation updates:
core/src/test/resources/ProfilingExpectations/nds_q88_photon_db_13_3_job_metrics_agg_expectation.csv
: Updated to include disk spill size metrics.core/src/test/resources/ProfilingExpectations/nds_q88_photon_db_13_3_sql_metrics_agg_expectation.csv
: Updated to include disk spill size metrics.core/src/test/resources/ProfilingExpectations/nds_q88_photon_db_13_3_stage_metrics_agg_expectation.csv
: Updated to include disk spill size metrics.nds_q88_photon_db_13_3.zstd
to include spill metrics