Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync-up the support of parse_url in qualification tool #1195

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

amahussein
Copy link
Collaborator

@amahussein amahussein commented Jul 16, 2024

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #1190

  • parse_url(,query[,]) should be treated as supported
  • parse_url(, ref|authority|file|userinfo[,]) shuld be treated as unsupported
  • Q tool will convert parse_url(ref|authority|file|userinfo) to parse_url_* to distinguish between different cases. This is a work around since the SQlPlanParser does not support arguments within expressions.
  • fix the unit-test

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1190

- parse_url(*,query,*) should be treated as supported
- fix the unit-test
@amahussein amahussein added bug Something isn't working core_tools Scope the core module (scala) labels Jul 16, 2024
@amahussein amahussein self-assigned this Jul 16, 2024
nartal1
nartal1 previously approved these changes Jul 16, 2024
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @amahussein !

parthosa
parthosa previously approved these changes Jul 16, 2024
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein. LGTM.

cindyyuanjiang
cindyyuanjiang previously approved these changes Jul 16, 2024
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein!

Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amahussein for making these changes.

@amahussein amahussein merged commit b31e00a into NVIDIA:dev Jul 17, 2024
14 checks passed
@amahussein amahussein deleted the spark-rapids-tools-1190 branch July 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sync-up the support of parse_url in qualification tool
4 participants